jorisvandenbossche commented on a change in pull request #11721:
URL: https://github.com/apache/arrow/pull/11721#discussion_r751083960



##########
File path: python/pyarrow/tests/test_compute.py
##########
@@ -85,6 +85,8 @@ def test_exported_functions():
     functions = exported_functions
     assert len(functions) >= 10
     for func in functions:
+        if func in (pc.index_in_meta_binary, pc.is_in_meta_binary):
+            continue

Review comment:
       Have to still look into this, but so for those two functions, the test 
was failing. 
   
   So the reason it was failing is because the metadata of the function is not 
fully consistent:
   ```
   In [13]: func = pc.function_registry().get_function("index_in_meta_binary")
   
   In [14]: pc._get_arg_names(func)
   Out[14]: []
   
   In [15]: func.arity
   Out[15]: 2
   ```
   
   I was using the arg_names for checking arity, but so in the case of the meta 
functions that apparently is not the same. I suppose that is because the 
`index_in_meta_binary` has no `doc` defined.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to