davisusanibar commented on a change in pull request #10883:
URL: https://github.com/apache/arrow/pull/10883#discussion_r751162888
##########
File path:
java/dataset/src/main/java/org/apache/arrow/dataset/jni/NativeScanTask.java
##########
@@ -35,7 +36,7 @@ public NativeScanTask(NativeScanner scanner) {
}
@Override
- public BatchIterator execute() {
+ public ArrowReader execute() {
Review comment:
Is there some numbers about to compare execution times for this change?
##########
File path:
java/dataset/src/test/java/org/apache/arrow/dataset/file/TestFileSystemDataset.java
##########
@@ -271,28 +281,34 @@ public void
testErrorThrownWhenIterateOnIteratorAfterTaskClose() throws Exceptio
NativeScanner scanner = dataset.newScan(options);
List<? extends NativeScanTask> tasks = collect(scanner.scan());
NativeScanTask task = tasks.get(0);
- ScanTask.BatchIterator iterator = task.execute();
+ ArrowReader reader = task.execute();
task.close();
- assertThrows(NativeInstanceReleasedException.class, iterator::hasNext);
+ assertThrows(NativeInstanceReleasedException.class, reader::loadNextBatch);
+ AutoCloseables.close(factory);
}
+ // After ARROW-7272: It's no longer possible to perform this check as we
pre-allocated
+ // container buffers in VectorSchemaRoot
+ @Ignore
Review comment:
Is there not coverage for file system dataset with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
