9prady9 edited a comment on pull request #11674: URL: https://github.com/apache/arrow/pull/11674#issuecomment-971586799
> > I assuming these functions are user facing(as they are exported), hence my comment. > > Ah, exporting vs not exporting is just whether the symbols are exposed in the resulting libraries (assuming you mean the ARROW_EXPORT macro); these functions live in the arrow::internal namespace and aren't meant to be used by end users (or at least, we don't really consider them part of the API/they're use-at-your-own-risk). These are all used internally to implement kernels and other things. Ah, in that case, it seems to me like there is no need for this change. Any internal use case that requires pop count on output can call the pop-count helper after output is computed right ? Especially, given (as per benchmark results we have seen so far) that co-computing output pop-count isn't giving any performance benefits. May I close this PR and leave a corresponding comment on JIRA issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
