pitrou commented on a change in pull request #11369:
URL: https://github.com/apache/arrow/pull/11369#discussion_r751382720
##########
File path: r/src/altrep.cpp
##########
@@ -237,29 +242,35 @@ struct AltrepVectorPrimitive : public
AltrepVectorBase<AltrepVectorPrimitive<sex
// array has nulls
//
// This only materialize the region, into buf. Not the entire vector.
- auto slice = GetArray(alt)->Slice(i, n);
+ auto slice = GetChunkedArray(alt)->Slice(i, n);
R_xlen_t ncopy = slice->length();
- // first copy the data buffer
- memcpy(buf, slice->data()->template GetValues<c_type>(1), ncopy *
sizeof(c_type));
+ c_type* out = buf;
+ for (const auto& array : slice->chunks()) {
+ auto n = array->length();
Review comment:
Call this something else? It conflicts with the `n` function argument,
which is error-prone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
