thisisnic commented on a change in pull request #11482:
URL: https://github.com/apache/arrow/pull/11482#discussion_r751419570
##########
File path: r/R/duckdb.R
##########
@@ -55,7 +55,7 @@
to_duckdb <- function(.data,
con = arrow_duck_connection(),
table_name = unique_arrow_tablename(),
- auto_disconnect = FALSE) {
+ auto_disconnect = TRUE) {
.data <- as_adq(.data)
duckdb::duckdb_register_arrow(con, table_name, .data)
Review comment:
Comment on line 70:
> # we should probably confirm that this use of src$disco is kosher.
Is this now confirmed?
##########
File path: r/R/duckdb.R
##########
@@ -55,7 +55,7 @@
to_duckdb <- function(.data,
con = arrow_duck_connection(),
table_name = unique_arrow_tablename(),
- auto_disconnect = FALSE) {
+ auto_disconnect = TRUE) {
.data <- as_adq(.data)
duckdb::duckdb_register_arrow(con, table_name, .data)
Review comment:
Comment on line 70:
> we should probably confirm that this use of src$disco is kosher.
Is this now confirmed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
