liukun4515 commented on a change in pull request #1311:
URL: https://github.com/apache/arrow-datafusion/pull/1311#discussion_r751874356
##########
File path: datafusion/src/logical_plan/mod.rs
##########
@@ -27,7 +27,7 @@ mod display;
mod expr;
mod extension;
mod operators;
-pub mod plan;
+mod plan;
Review comment:
@Jimexist @alamb
I have doubts about this backward compatible.
Before this commit #1290, this is `mod plan`, and this commit is not in the
release 6.0.0 datafusion.
The reason i did this is to keep code style with original usage:
```
pub use plan::{
JoinConstraint, JoinType, LogicalPlan, Partitioning, PlanType,
PlanVisitor,
};
```
and make some struct public we wanted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
