xudong963 commented on a change in pull request #1325:
URL: https://github.com/apache/arrow-datafusion/pull/1325#discussion_r753362289
##########
File path: datafusion/src/optimizer/constant_folding.rs
##########
@@ -107,7 +107,7 @@ impl OptimizerRule for ConstantFolding {
utils::from_plan(plan, &expr, &new_inputs)
}
- LogicalPlan::TableScan { .. } | LogicalPlan::EmptyRelation { .. }
=> {
+ LogicalPlan::TableScan { .. } | LogicalPlan::EmptyRelation(_) => {
Review comment:
nit: keep consistent. `{ .. }` `(_)`
##########
File path: datafusion/src/logical_plan/plan.rs
##########
@@ -263,19 +292,9 @@ pub enum LogicalPlan {
/// Produces rows from a table provider by reference or from the context
TableScan(TableScanPlan),
/// Produces no rows: An empty relation with an empty schema
- EmptyRelation {
- /// Whether to produce a placeholder row
- produce_one_row: bool,
- /// The schema description of the output
- schema: DFSchemaRef,
- },
+ EmptyRelation(EmptyRelation),
/// Produces the first `n` tuples from its input and discards the rest.
- Limit {
- /// The limit
- n: usize,
- /// The logical plan
- input: Arc<LogicalPlan>,
- },
+ Limit(Limit),
Review comment:
Using a different name will be better, such as `LimitPlan`, keep the
same as others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
