lidavidm commented on a change in pull request #10260:
URL: https://github.com/apache/arrow/pull/10260#discussion_r753523207



##########
File path: cpp/cmake_modules/DefineOptions.cmake
##########
@@ -371,6 +371,9 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL 
"${CMAKE_CURRENT_SOURCE_DIR}")
 
   define_option(ARROW_WITH_BACKTRACE "Build with backtrace support" ON)
 
+  define_option(ARROW_WITH_OPENTELEMETRY
+                "Build libraries with OpenTelemetry support for distributed 
tracing" OFF)

Review comment:
       Hmm, perhaps. It seems a little odd since it's not its own top-level 
directory (and not its own user-facing API) like the other components generally 
are, and I think we'd want ARROW_ENGINE and perhaps ARROW_FLIGHT to require 
OpenTelemetry at some point. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to