liukun4515 commented on a change in pull request #1309:
URL: https://github.com/apache/arrow-datafusion/pull/1309#discussion_r753619546



##########
File path: ballista/rust/core/src/serde/logical_plan/to_proto.rs
##########
@@ -778,43 +779,43 @@ impl TryInto<protobuf::LogicalPlanNode> for &LogicalPlan {
                     )))
                 }
             }
-            LogicalPlan::Projection {
-                expr, input, alias, ..
-            } => Ok(protobuf::LogicalPlanNode {
+            LogicalPlan::Projection(projection_plan) => 
Ok(protobuf::LogicalPlanNode {

Review comment:
       Same comment in the [pull 
request](https://github.com/apache/arrow-datafusion/pull/1326#discussion_r753618119)
   @xudong963 how about make consistent like before?
   If the changes is suffering for multi contributors, we can fill a follow up 
pull request to make consistent.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to