Jimexist commented on pull request #888: URL: https://github.com/apache/arrow-rs/pull/888#issuecomment-974671577
> Looks pretty cool to me. I am not sure how widely used the `Float16` type is but seems like a reasonable feature to add > > I think it would be good to add some basic tests for `Float16Array` (like, for example, creating it from an iterator) as well as an example as a doc comment). > > I also was wondering if there was some way to avoid the sprinkled `#[cfg(feature = "f16")]` throughout the code (for example, can we possible always define `Float16Array` even if the `f16` type is not defined, but provide some implementation that always errors when it is constructed. > > Then we could have one or two `#[cfg(feature = "f16")]` checks rather than them throughout the code > can we possible always define Float16Array even if the f16 type is not defined, but provide some implementation that always errors when it is constructed. are you saying that we should allow for runtime error rather than compile time failures? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
