houqp opened a new pull request #1347: URL: https://github.com/apache/arrow-datafusion/pull/1347
# Rationale for this change I noticed this when I bump datafusion to in roapi and one of our tests started to fail. Two reasons that I think changing to true might be better: * For serious production use-cases, collecting stats should make a big different in performance for cases where it could help. It would be good to default to the more performant setup. Ignoring stats seems to be the less common use-case that we can ask users to manually specify it. * Be backwards compatible. @rdettai curious what's your thought on this. I will add a test case to guard against regression if everyone agrees with the direction. # What changes are included in this PR? Default value for `collect_stat` changed to `true`. # Are there any user-facing changes? Yes, reverting back to the 5.x behavior. <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
