Jimexist commented on a change in pull request #819:
URL: https://github.com/apache/arrow-datafusion/pull/819#discussion_r753901912
##########
File path: python/src/functions.rs
##########
@@ -85,6 +86,63 @@ fn concat_ws(sep: String, args: Vec<PyExpr>) ->
PyResult<PyExpr> {
Ok(logical_plan::concat_ws(sep, &args).into())
}
+/// Creates a new Sort expression
+#[pyfunction]
+fn order_by(
+ expr: PyExpr,
+ asc: Option<bool>,
+ nulls_first: Option<bool>,
+) -> PyResult<PyExpr> {
+ Ok(PyExpr {
+ expr: datafusion::logical_plan::Expr::Sort {
+ expr: Box::new(expr.expr),
+ asc: asc.unwrap_or(true),
+ nulls_first: nulls_first.unwrap_or(true),
+ },
+ })
+}
+
+/// Creates a new Alias expression
+#[pyfunction]
+fn alias(expr: PyExpr, name: &str) -> PyResult<PyExpr> {
+ Ok(PyExpr {
+ expr: datafusion::logical_plan::Expr::Alias(
+ Box::new(expr.expr),
+ String::from(name),
+ ),
+ })
+}
Review comment:
do you think alias should be a method on the expression or column object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
