romainfrancois commented on a change in pull request #11751:
URL: https://github.com/apache/arrow/pull/11751#discussion_r754316667
##########
File path: r/R/type.R
##########
@@ -107,17 +111,48 @@ UInt32 <- R6Class("UInt32", inherit = FixedWidthType)
UInt64 <- R6Class("UInt64", inherit = FixedWidthType)
Float16 <- R6Class("Float16", inherit = FixedWidthType)
Float32 <- R6Class("Float32", inherit = FixedWidthType)
-Float64 <- R6Class("Float64", inherit = FixedWidthType)
+Float64 <- R6Class("Float64",
+ inherit = FixedWidthType,
+ public = list(
+ code = function() call("float64")
+ )
+)
Review comment:
🤔 however the flip side is that when not used in `schema()` this is
confusing now:
``` r
arrow::float64()$code()
#> double()
```
<sup>Created on 2021-11-22 by the [reprex
package](https://reprex.tidyverse.org) (v2.0.1.9000)</sup>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
