dragosmg commented on a change in pull request #11758:
URL: https://github.com/apache/arrow/pull/11758#discussion_r754963470
##########
File path: r/R/type.R
##########
@@ -187,8 +187,11 @@ NestedType <- R6Class("NestedType", inherit = DataType)
#' @param timezone For `timestamp()`, an optional time zone string.
#' @param byte_width byte width for `FixedSizeBinary` type.
#' @param list_size list size for `FixedSizeList` type.
-#' @param precision For `decimal()`, precision
-#' @param scale For `decimal()`, scale
+#' @param precision For `decimal()`, the number of significant digits
+#' the arrow `decimal` type can represent. Currently `decimal()` is mapped
+#' to `DecimalType128`, having a maximum precision of 38 significant digits.
Review comment:
decimal256 is not exposed yet. I am planning on opening a bunch of
tickets to:
* deprecate `decimal()` and replace it with `decimal128()`
* implement `decimal256()`.
* maybe open another ticket to agree on a formalised approach to deprecation
(both for functions and arguments). It would be relevant both for this PR and
for `write_csv_arrow()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
