pitrou commented on a change in pull request #11694:
URL: https://github.com/apache/arrow/pull/11694#discussion_r755133533



##########
File path: cpp/src/arrow/array/builder_binary.h
##########
@@ -372,6 +372,8 @@ class BaseBinaryBuilder : public ArrayBuilder {
     return util::string_view(reinterpret_cast<const char*>(value_data), 
value_length);
   }
 
+  util::string_view operator[](int64_t i) const { return GetView(i); }

Review comment:
       No, but I don't think they need `operator[]` either. This PR should only 
touch array classes, IMHO.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to