jorisvandenbossche commented on pull request #11757: URL: https://github.com/apache/arrow/pull/11757#issuecomment-976596291
> Would it be a good idea to also mention + link to our code of conduct and call out (or reiterate) that reviews (both from the reviewer and the author) must respect the code of conduct ( +1 > I also wonder if it would be good to have a section about reviews being collaborative and everyone should try their best to keep them professional and solutions oriented? This cuts in both ways: it can be easy for a PR author to feel a bit down/attacked if there are lots of changes requested (and mentioning this + framing the review process as a collaborative one might help resolve some of that) and it also reminds reviewers to some empathy in their reviewing. Yes, I agree it would be nice to have a section on this, explicitly calling this out. Maybe we could also mention a general guideline along the lines of "assume good intentions" (eg if you might feel attacked by the review), as well as avoiding "strong" wording on the reviewers side (like "this is wrong" can also be phrased as "I think we should do it this way instead"). This blogpost of Gael Varoqaux is a nice reference about this IMO: http://gael-varoquaux.info/programming/technical-discussions-are-hard-a-few-tips.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
