pitrou commented on a change in pull request #11766:
URL: https://github.com/apache/arrow/pull/11766#discussion_r756243210
##########
File path: dev/archery/archery/cli.py
##########
@@ -494,7 +494,12 @@ def benchmark_run(ctx, rev_or_path, src, preserve, output,
cmake_extras,
repetitions=repetitions,
benchmark_filter=benchmark_filter)
- json.dump(runner_base, output, cls=JsonEncoder)
+ # XXX for some weird reason, running the benchmarks is coupled
+ # with JSON-encoding their results, so need to run `json` on
+ # the benchmark runner even when no JSON output is requested.
Review comment:
@bkietz @fsaintjacques Do you remember why this was done this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
