jorisvandenbossche commented on a change in pull request #11765:
URL: https://github.com/apache/arrow/pull/11765#discussion_r756690083
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -967,6 +967,18 @@ class MakeStructOptions(_MakeStructOptions):
self._set_options(field_names, field_nullability, field_metadata)
+cdef class _StructFieldOptions(FunctionOptions):
+ def _set_options(self, indices):
+ self.wrapped.reset(new CStructFieldOptions(indices))
+
+
+class StructFieldOptions(_StructFieldOptions):
+ def __init__(self, indices=None):
+ if indices is None:
+ indices = []
Review comment:
For this specific case, do we actually want to allow not specifying any
StructFieldOptions? (thus the default None here)
That would not select any field, which doesn't make much sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
