rkavanap commented on a change in pull request #10884:
URL: https://github.com/apache/arrow/pull/10884#discussion_r756833961
##########
File path: cpp/src/gandiva/llvm_generator.cc
##########
@@ -170,6 +170,9 @@ llvm::Value* LLVMGenerator::GetDataReference(llvm::Value*
arg_addrs, int idx,
llvm::Value* load = LoadVectorAtIndex(arg_addrs, idx, name);
Review comment:
Not sure. But should we add this null type to supported types so that
dremio can see this null type as a supported type. there seems to be some code
in llvm_types.h for supported types. But I do not know this well enough to know
whether you have to add something to supported types, so that dremio knows that
Gandiva can be used as a viable codegen for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
