alamb opened a new pull request #1374:
URL: https://github.com/apache/arrow-datafusion/pull/1374


   # Which issue does this PR close?
   
   Re https://github.com/apache/arrow-datafusion/issues/1160 (more 
sophisticated expression simplification)
   
    # Rationale for this change
   There are at least three places where expressions are simplified, with some 
overlap: `const_evaluator.rs`, `expression_simplifier.rs`, and 
`optimizer/util.rs`
   
   This makes it hard both to understand what simplifications are applied, as 
well as what is redundant (e.g. 
https://github.com/apache/arrow-datafusion/pull/1164)
   
   # What changes are included in this PR?
   1. Move `ConstEvaluator` and `Simplifier` logic and tests into 
`expression_simplifier.rs`.
   2. Rename some tests
   
   # Are there any user-facing changes?
   The location of `ConstEvaluator` has changed
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to