alamb opened a new pull request #1375:
URL: https://github.com/apache/arrow-datafusion/pull/1375


   # Which issue does this PR close?
   
   Builds on https://github.com/apache/arrow-datafusion/pull/1374
   
   Re https://github.com/apache/arrow-datafusion/issues/1160 (more 
sophisticated expression simplification)
   
    # Rationale for this change
   `ConstantFolding` and `SimplifyExpression` both simplify expressions, in 
slightly different ways, which is confusing and redundant. It also means bug 
fixes such as #1319 didn't get applied to `SimplifyExpression`.
   
   # What changes are included in this PR?
   1. Combine `ConstantFolding` into `SimplifyExpression` optimizer pass
   2. Move tests
   
   Note:
   I plan one final PR to combine `simplify` and `Simplifier` logic but to keep 
reviews easier I am going to do that in another PR
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to