pablosichert commented on a change in pull request #10772:
URL: https://github.com/apache/arrow/pull/10772#discussion_r757956992
##########
File path: cpp/src/gandiva/llvm_types.h
##########
@@ -57,14 +58,20 @@ class GANDIVA_EXPORT LLVMTypes {
llvm::PointerType* ptr_type(llvm::Type* type) { return type->getPointerTo();
}
+ llvm::PointerType* opaque_ptr_type() { return ptr_type(i8_type()); }
Review comment:
That's because LLVM doesn't support opaque pointer types yet, see
http://nondot.org/~sabre/LLVMNotes/EliminatingVoid.txt and
https://llvm.org/docs/OpaquePointers.html.
Will add a comment here, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
