kou commented on a change in pull request #11735:
URL: https://github.com/apache/arrow/pull/11735#discussion_r757971507
##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -622,7 +637,7 @@ test_linux_wheels() {
for tag in ${platform_tags}; do
# check the mandatory and optional imports
pip install --force-reinstall
python-rc/${VERSION}-rc${RC_NUMBER}/pyarrow-${VERSION}-cp${py_arch//[mu.]/}-cp${py_arch//./}-${tag}.whl
- INSTALL_PYARROW=OFF ${ARROW_DIR}/ci/scripts/python_wheel_unix_test.sh
${ARROW_DIR}
+ INSTALL_PYARROW=OFF ${ARROW_DIR}/ci/scripts/python_wheel_unix_test.sh
${ARROW_TMPDIR}/apache-arrow-${VERSION}
Review comment:
How about removing the existing `ARROW_DIR="..."` and defining
`ARROW_DIR` in `get_or_decompress_source()` instead`?
##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -531,16 +531,33 @@ test_integration() {
$INTEGRATION_TEST_ARGS
}
-clone_testing_repositories() {
- # Clone testing repositories if not cloned already
- if [ ! -d "arrow-testing" ]; then
- git clone https://github.com/apache/arrow-testing.git
+get_or_decompress_source() {
+ dist_name="apache-arrow-${VERSION}"
+ if [ ${TEST_SOURCE} -gt 0 ] || [ ${TEST_WHEELS} == 1 ]; then
Review comment:
```suggestion
if [ $((${TEST_SOURCE} + ${TEST_WHEELS})) -gt 0 ]; then
```
##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -531,16 +531,33 @@ test_integration() {
$INTEGRATION_TEST_ARGS
}
-clone_testing_repositories() {
- # Clone testing repositories if not cloned already
- if [ ! -d "arrow-testing" ]; then
- git clone https://github.com/apache/arrow-testing.git
+get_or_decompress_source() {
+ dist_name="apache-arrow-${VERSION}"
+ if [ ${TEST_SOURCE} -gt 0 ] || [ ${TEST_WHEELS} == 1 ]; then
+ import_gpg_keys
+ if [ ! -d "${dist_name}" ]; then
+ fetch_archive ${dist_name}
+ tar xf ${dist_name}.tar.gz
+ fi
+ else
+ mkdir -p ${dist_name}
+ if [ ! -f ${TEST_ARCHIVE} ]; then
+ echo "${TEST_ARCHIVE} not found"
+ exit 1
+ fi
+ tar xf ${TEST_ARCHIVE} -C ${dist_name} --strip-components=1
+ fi
+ # clone testing repositories
+ cd ${dist_name}
Review comment:
```suggestion
pushd ${dist_name}
```
##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -531,16 +531,33 @@ test_integration() {
$INTEGRATION_TEST_ARGS
}
-clone_testing_repositories() {
- # Clone testing repositories if not cloned already
- if [ ! -d "arrow-testing" ]; then
- git clone https://github.com/apache/arrow-testing.git
+get_or_decompress_source() {
Review comment:
How about `ensure_source`?
##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -531,16 +531,33 @@ test_integration() {
$INTEGRATION_TEST_ARGS
}
-clone_testing_repositories() {
- # Clone testing repositories if not cloned already
- if [ ! -d "arrow-testing" ]; then
- git clone https://github.com/apache/arrow-testing.git
+get_or_decompress_source() {
+ dist_name="apache-arrow-${VERSION}"
+ if [ ${TEST_SOURCE} -gt 0 ] || [ ${TEST_WHEELS} == 1 ]; then
+ import_gpg_keys
+ if [ ! -d "${dist_name}" ]; then
+ fetch_archive ${dist_name}
+ tar xf ${dist_name}.tar.gz
+ fi
+ else
+ mkdir -p ${dist_name}
+ if [ ! -f ${TEST_ARCHIVE} ]; then
+ echo "${TEST_ARCHIVE} not found"
+ exit 1
+ fi
+ tar xf ${TEST_ARCHIVE} -C ${dist_name} --strip-components=1
+ fi
+ # clone testing repositories
+ cd ${dist_name}
+ if [ ! -d "testing/data" ]; then
+ git clone https://github.com/apache/arrow-testing.git testing
fi
- if [ ! -d "parquet-testing" ]; then
- git clone https://github.com/apache/parquet-testing.git
+ if [ ! -d "cpp/submodules/parquet-testing/data" ]; then
+ git clone https://github.com/apache/parquet-testing.git
cpp/submodules/parquet-testing
fi
- export ARROW_TEST_DATA=$PWD/arrow-testing/data
- export PARQUET_TEST_DATA=$PWD/parquet-testing/data
+ export ARROW_TEST_DATA=$PWD/testing/data
+ export PARQUET_TEST_DATA=$PWD/cpp/submodules/parquet-testing/data
+ cd ..
Review comment:
```suggestion
popd
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
