kou commented on a change in pull request #11337:
URL: https://github.com/apache/arrow/pull/11337#discussion_r758069556
##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -380,7 +380,7 @@ if(ARROW_COMPUTE)
compute/exec/hash_join.cc
compute/exec/hash_join_dict.cc
compute/exec/hash_join_node.cc
- compute/exec/ir_consumer.cc
+ compute/exec/ir_consumer.cc
Review comment:
Could you revert a needless change?
##########
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##########
@@ -445,6 +445,30 @@ static void VisitTwoArrayValuesInline(const ArrayData&
arr0, const ArrayData& ar
arr0.length, std::move(visit_valid),
std::move(visit_null));
}
+template <typename Arg0Type, typename Arg1Type, typename Arg2Type,
+ typename VisitFunc, typename NullFunc>
+static void VisitThreeArrayValuesInline(const ArrayData& arr0, const
ArrayData& arr1,
+ const ArrayData& arr2,
+ VisitFunc&& valid_func, NullFunc&&
null_func) {
Review comment:
Is this indent accepted by lint?
Could you remove "WIP" from the pull request title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
