wjones127 commented on a change in pull request #11714:
URL: https://github.com/apache/arrow/pull/11714#discussion_r758814528
##########
File path: r/configure.win
##########
@@ -52,7 +53,7 @@ function configure_release() {
# NOTE: If you make changes to the libraries below, you should also change
# ci/scripts/r_windows_build.sh and ci/scripts/PKGBUILD
PKG_CFLAGS="-I${RWINLIB}/include -DARROW_STATIC -DPARQUET_STATIC
-DARROW_DS_STATIC -DARROW_R_WITH_ARROW -DARROW_R_WITH_PARQUET
-DARROW_R_WITH_DATASET -DARROW_R_WITH_JSON"
- PKG_LIBS="-L${RWINLIB}/lib"'$(subst gcc,,$(COMPILED_BY))$(R_ARCH)
'"-L${RWINLIB}/lib"'$(R_ARCH)$(CRT) '"-lparquet -larrow_dataset -larrow
-larrow_bundled_dependencies -lutf8proc -lthrift -lsnappy -lz -lzstd -llz4
-lole32 ${MIMALLOC_LIBS} ${OPENSSL_LIBS}"
+ PKG_LIBS="-L${RWINLIB}/lib"'$(subst gcc,,$(COMPILED_BY))$(R_ARCH)
'"-L${RWINLIB}/lib"'$(R_ARCH)$(CRT) '"-lparquet -larrow_dataset -larrow
-larrow_bundled_dependencies -lutf8proc -lthrift -lsnappy -lz -lzstd -llz4
${BROTLI_LIBS} -lole32 ${MIMALLOC_LIBS} ${OPENSSL_LIBS}"
Review comment:
Yes, I'll wrap them to 90 chars. Also doing that for the aws libs list
near the top.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
