pitrou commented on a change in pull request #11789:
URL: https://github.com/apache/arrow/pull/11789#discussion_r759106445
##########
File path: cpp/src/arrow/compute/exec/key_compare.cc
##########
@@ -276,8 +276,9 @@ void KeyCompare::CompareVarBinaryColumnToRow(
uint64_t key_right = key_right_ptr[j];
result_or |= key_left ^ key_right;
}
- uint64_t tail_mask = ~0ULL >> (64 - 8 * (length - j * 8));
- uint64_t key_left = util::SafeLoad(key_left_ptr + j);
+ int32_t tail_length = length - j * 8;
+ uint64_t tail_mask = ~0ULL >> (64 - 8 * (tail_length));
Review comment:
I find the parens spare me the need of looking up C++ operator
precedence rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
