dragosmg commented on a change in pull request #11790:
URL: https://github.com/apache/arrow/pull/11790#discussion_r759094997
##########
File path: r/tests/testthat/test-data-type.R
##########
@@ -395,6 +395,18 @@ test_that("decimal type and validation", {
expect_error(decimal(4, NA), '"scale" must be an integer')
expect_r6_class(decimal(4, 2), "Decimal128Type")
+
+ expect_error(decimal128())
+ expect_error(decimal128("four"), '"precision" must be an integer')
+ expect_error(decimal128(4))
Review comment:
Row 400 should be checked as that comes from the body of the R function
where we check the args. I'd be in favour of keeping all of them.
Rows 399 & 401: same as for the other arg to `decimal128()`, this is a
generic R error: `Error in decimal128(4) : argument "scale" is missing, with no
default`. I merely duplicated the tests we had for `decimal()`. Given it's the
rather generic R error, I'd say assertion on content might not be needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
