jvictorhuguenin commented on a change in pull request #11471:
URL: https://github.com/apache/arrow/pull/11471#discussion_r759317758
##########
File path: cpp/src/gandiva/like_holder.cc
##########
@@ -22,10 +22,20 @@
#include "gandiva/regex_util.h"
namespace gandiva {
+RE2 LikeHolder::starts_with_regex_(R"((\w|\s|\\-)*\.\*)");
+RE2 LikeHolder::ends_with_regex_(R"(\.\*(\w|\s|\\-)*)");
+RE2 LikeHolder::is_substr_regex_(R"(\.\*(\w|\s|\\-)*\.\*)");
-RE2 LikeHolder::starts_with_regex_(R"((\w|\s)*\.\*)");
-RE2 LikeHolder::ends_with_regex_(R"(\.\*(\w|\s)*)");
-RE2 LikeHolder::is_substr_regex_(R"(\.\*(\w|\s)*\.\*)");
+std::string& RemovePatternEscapeChars(const FunctionNode& node, std::string&
pattern) {
+ if (node.children().size() != 2) {
Review comment:
There's already one(TestUtf8.TestLikeWithEscape), this is needed because
when a % is escaped the SqlLikePatternToPcre keeps the escape char interfering
on the string to search on starts_with expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
