alamb commented on a change in pull request #987:
URL: https://github.com/apache/arrow-rs/pull/987#discussion_r759682090
##########
File path: parquet/src/arrow/arrow_reader.rs
##########
@@ -670,6 +670,7 @@ mod tests {
}
#[test]
+ #[ignore]
Review comment:
This test fails as follows:
```
---- arrow::arrow_reader::tests::test_read_maps stdout ----
thread 'arrow::arrow_reader::tests::test_read_maps' panicked at 'called
`Result::unwrap()` on an `Err` value: InvalidArgumentError("Child type mismatch
for Struct([Field { name: \"key\", data_type: Utf8, nullable: false, dict_id:
0, dict_is_ordered: false, metadata: None }, Field { name: \"value\",
data_type: Map(Field { name: \"key_value\", data_type: Struct([Field { name:
\"key\", data_type: Int32, nullable: false, dict_id: 0, dict_is_ordered: false,
metadata: None }, Field { name: \"value\", data_type: Boolean, nullable: false,
dict_id: 0, dict_is_ordered: false, metadata: None }]), nullable: false,
dict_id: 0, dict_is_ordered: false, metadata: None }, false), nullable: true,
dict_id: 0, dict_is_ordered: false, metadata: None }]). Expected Map(Field {
name: \"key_value\", data_type: Struct([Field { name: \"key\", data_type:
Int32, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: None },
Field { name: \"value\", data_type: Boolean, nullable: false, dict_id: 0, dict
_is_ordered: false, metadata: None }]), nullable: false, dict_id: 0,
dict_is_ordered: false, metadata: None }, false) but child data had Map(Field {
name: \"key_value\", data_type: Struct([Field { name: \"key\", data_type:
Int32, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: None },
Field { name: \"value\", data_type: Boolean, nullable: false, dict_id: 0,
dict_is_ordered: false, metadata: None }]), nullable: true, dict_id: 0,
dict_is_ordered: false, metadata: None }, false)")',
arrow/src/array/data.rs:308:34
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
(the issue is the nullability of the child field is declared differently on
the Struct's datatype than on the ArrayData)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]