liukun4515 commented on pull request #1387: URL: https://github.com/apache/arrow-datafusion/pull/1387#issuecomment-984260169
> but overall I think this is looking almost ready to merge > Thanks @liukun4515 I really like where this is heading and it makes sense to me to have aggregate coercion rules that are separate from coercion rules for other functions. > > I am curious how you see the overall code structure evolving. Is your idea that there will be several coercion modules, for each different Expr type, for example? > > ``` > datafusion/src/physical_plan/coercion_rule/aggregate_rule.rs > datafusion/src/physical_plan/coercion_rule/function.rs > datafusion/src/physical_plan/coercion_rule/operators.rs > ``` Yes, this is the future result and diff type exprs have diff coercion rule in diff file. The code structure will look like the example your provided. > I had a few suggestions / comments, but overall I think this is looking almost ready to merge > > Thank you for starting this work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
