dragosmg commented on a change in pull request #11668:
URL: https://github.com/apache/arrow/pull/11668#discussion_r761029566
##########
File path: r/R/csv.R
##########
@@ -415,6 +415,16 @@ CsvReadOptions$create <- function(use_threads =
option_use_threads(),
)
}
+readr_to_csv_write_options <- function(include_header,
+ batch_size = 1024L) {
+ assert_that(is_integerish(batch_size, n = 1, finite = TRUE), batch_size > 0)
Review comment:
Should we aim for a more informative error message here?
```
> write_csv_arrow(my_tibble, csv_file, batch_size = Inf)
Error: is_integerish(x = batch_size, n = 1, finite = TRUE) is not TRUE
```
might not be the easiest to digest by a user encountering
`rlang::is_integerish()` for the first time. We also offer no direction for
further action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
