augustoasilva commented on a change in pull request #11193:
URL: https://github.com/apache/arrow/pull/11193#discussion_r761502021
##########
File path: cpp/src/gandiva/cache.h
##########
@@ -39,17 +39,17 @@ class Cache {
Cache() : Cache(GetCapacity()) {}
- ValueType GetModule(KeyType cache_key) {
+ ValueType GetObjectCode(KeyType cache_key) {
arrow::util::optional<ValueCacheObject<ValueType>> result;
mtx_.lock();
result = cache_.get(cache_key);
mtx_.unlock();
return result != arrow::util::nullopt ? (*result).module : nullptr;
}
- void PutModule(KeyType cache_key, ValueCacheObject<ValueType>
valueCacheObject) {
+ void PutObjectCode(KeyType& cache_key, ValueCacheObject<ValueType>
object_code) {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
