alamb commented on a change in pull request #1000:
URL: https://github.com/apache/arrow-rs/pull/1000#discussion_r762437095



##########
File path: arrow/Cargo.toml
##########
@@ -40,15 +40,15 @@ path = "src/lib.rs"
 serde = { version = "1.0", features = ["rc"] }
 serde_derive = "1.0"
 serde_json = { version = "1.0", features = ["preserve_order"] }
-indexmap = "1.6"
+indexmap = { version = "1.6", features = ["std"] }

Review comment:
       I know some arrow users target `wasm` which has some strange semantics 
related to std, however, we have a test for compiling with a `wasm` target, and 
those seem to have passed on this PR: 
   
   https://github.com/apache/arrow-rs/runs/4413147281?check_suite_focus=true
   
   fyi @roee88 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to