alamb commented on a change in pull request #1401:
URL: https://github.com/apache/arrow-datafusion/pull/1401#discussion_r762449354
##########
File path: datafusion/src/optimizer/simplify_expressions.rs
##########
@@ -1262,25 +1252,8 @@ mod tests {
// Make sure c1 column to be used in tests is not boolean type
assert_eq!(col("c1").get_type(&schema).unwrap(), DataType::Utf8);
- // don't fold c1 = true
- assert_eq!(
Review comment:
as c1 is a string column, it is a runtime error to try and evaluate `c1
= true` -- I fixed the case and removed the nonsensical tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
