domoritz commented on pull request #11701: URL: https://github.com/apache/arrow/pull/11701#issuecomment-986959204
We don't have these checks for node anywhere else since they are brittle. Instead, it would be better to use different files such as https://github.com/apache/arrow/blob/master/js/src/Arrow.node.ts and https://github.com/apache/arrow/blob/master/js/src/Arrow.dom.ts. Also, could you clarify which node version is considered old here? It's important to know so we can remove the patch when node deprecates the old version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
