ahmet-uyar commented on a change in pull request #11872:
URL: https://github.com/apache/arrow/pull/11872#discussion_r763222328
##########
File path: cpp/src/arrow/ipc/read_write_test.cc
##########
@@ -1727,6 +1727,52 @@ TEST(TestIpcFileFormat, FooterMetaData) {
ASSERT_TRUE(out_metadata->Equals(*metadata));
}
+TEST_F(TestWriteRecordBatch, CompressionRatio) {
+ // ARROW-8823: Calculating the compression ratio
+ FileWriterHelper helper;
+ IpcWriteOptions write_options1 = IpcWriteOptions::Defaults();
+ IpcWriteOptions write_options2 = IpcWriteOptions::Defaults();
+ ASSERT_OK_AND_ASSIGN(write_options2.codec,
util::Codec::Create(Compression::LZ4_FRAME));
+
+ // pre-computed compression ratios for record batches with
Compression::LZ4_FRAME
+ std::vector<float> comp_ratios{1.0f, 0.64f, 0.79924363f};
Review comment:
added raw record batch sizes instead.
##########
File path: cpp/src/arrow/ipc/read_write_test.cc
##########
@@ -1727,6 +1727,52 @@ TEST(TestIpcFileFormat, FooterMetaData) {
ASSERT_TRUE(out_metadata->Equals(*metadata));
}
+TEST_F(TestWriteRecordBatch, CompressionRatio) {
+ // ARROW-8823: Calculating the compression ratio
+ FileWriterHelper helper;
+ IpcWriteOptions write_options1 = IpcWriteOptions::Defaults();
+ IpcWriteOptions write_options2 = IpcWriteOptions::Defaults();
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
