emkornfield commented on a change in pull request #11849:
URL: https://github.com/apache/arrow/pull/11849#discussion_r763443603
##########
File path: cpp/src/arrow/csv/writer_test.cc
##########
@@ -37,24 +38,34 @@ struct WriterTestParams {
std::shared_ptr<Schema> schema;
std::string batch_data;
WriteOptions options;
- bool options_invalid;
+ // When set, expect the test to fail just from the supplied WriteOptions
alone.
+ bool expect_invalid_options;
std::string expected_output;
+ // When set, expect the test to fail with this string.
+ util::optional<std::string> expect_invalid_string;
Review comment:
can you use a status memory instead of the two separate additional
parameter here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
