Dandandan commented on a change in pull request #1402:
URL: https://github.com/apache/arrow-datafusion/pull/1402#discussion_r763674180
##########
File path: datafusion/src/logical_plan/plan.rs
##########
@@ -38,7 +38,7 @@ pub enum JoinType {
Inner,
/// Left Join
Left,
- /// Right Join
+ /// Right Join: will be transferred to Left Join
Review comment:
Won't removing the right join effectively mean we can't reorder a left
join to a right join?
When a left join has a bigger side on the left it means we would like to
swap the sides and the join implementation.
Besides hashing there is also the producing rows that didn't match. For a
left join this is done at the end, while for the right join this can be done
for each `RecordBatch`.
It might be a bit strange to encode a different left/right enum, because for
inner, outer, etc. that doesn't make a lot of sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
