coryan commented on a change in pull request #11842:
URL: https://github.com/apache/arrow/pull/11842#discussion_r764199176
##########
File path: cpp/src/arrow/filesystem/gcsfs.cc
##########
@@ -275,12 +273,67 @@ class GcsFileSystem::Impl {
const GcsOptions& options() const { return options_; }
Result<FileInfo> GetFileInfo(const GcsPath& path) {
- if (!path.object.empty()) {
- auto meta = client_.GetObjectMetadata(path.bucket, path.object);
- return GetFileInfoImpl(path, std::move(meta).status(), FileType::File);
+ if (path.object.empty()) {
+ auto meta = client_.GetBucketMetadata(path.bucket);
+ return GetFileInfoImpl(path, std::move(meta).status(),
FileType::Directory);
}
- auto meta = client_.GetBucketMetadata(path.bucket);
- return GetFileInfoImpl(path, std::move(meta).status(),
FileType::Directory);
+ auto meta = client_.GetObjectMetadata(path.bucket, path.object);
+ return GetFileInfoImpl(
+ path, std::move(meta).status(),
+ path.object.back() == '/' ? FileType::Directory : FileType::File);
+ }
+
+ // GCS does not have directories or folders. But folders can be emulated
(with some
+ // limitations) using marker objects. That and listing with prefixes
creates the
+ // illusion of folders.
+ google::cloud::Status CreateDirMarker(const std::string& bucket,
+ util::string_view name) {
+ // Make the name canonical.
+ const auto canonical = internal::EnsureTrailingSlash(name);
+ return client_
+ .InsertObject(bucket, canonical, "arrow gcsfs directory " + canonical,
Review comment:
Changed the object to be 0-byte, it makes little difference either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
