thisisnic commented on a change in pull request #11837:
URL: https://github.com/apache/arrow/pull/11837#discussion_r764252291
##########
File path: docs/source/developers/guide/step_by_step/pr_and_github.rst
##########
@@ -24,14 +24,168 @@
.. _pr_and_github:
-****************************
-Lifecycle of a Pull Request
-****************************
+******************************
+Lifecycle of a Pull Request 🙀
+******************************
+:ref:`As mentioned before<set-up>`, the Arrow project uses git for
+version control and a workflow based on Pull Requests. That means
+that you contribute the changes to the code by creating a branch
+in Git, make changes to the code, push the changes to your ``origin``
+which is your fork of the Arrow repository on GitHub and then you
+create a **Pull Request** against the official Arrow repository
+which is saved in your set up as ``upstream``.
-Creating a PR 🙀
-================
+You should have git set up by now, have cloned the repository,
+have successfully built Arrow and have an JIRA issue to work on.
+**Before making changes to the code, you should create a new
+branch in Git.**
-Reviews and get the PR merge 🎉
-===============================
\ No newline at end of file
+1. Update/sync the code from your ``upstream``
+ in the master branch. Run it in the shell from ``arrow`` directory.
+
+ .. code:: console
+
+ $ git checkout master
+ $ git fetch upstream
+ $ git pull --ff-only upstream master
Review comment:
How about adding comments explaining what each of these rows are doing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
