jorgecarleitao commented on a change in pull request #779:
URL: https://github.com/apache/arrow-rs/pull/779#discussion_r764597928
##########
File path: arrow/src/compute/kernels/sort.rs
##########
@@ -243,6 +243,11 @@ pub fn sort_to_indices(
DataType::Interval(IntervalUnit::DayTime) => {
sort_primitive::<IntervalDayTimeType, _>(values, v, n, cmp,
&options, limit)
}
+ DataType::Interval(IntervalUnit::MonthDayNano) => {
+ sort_primitive::<IntervalMonthDayNanoType, _>(
Review comment:
I think that in general the time intervals do not have an natural order
without an associated datetime pinning them to a specific time line. The
conversion `month,days,nanos -> seconds` is lossy because one day is not 24
hours (some days are 23 and others 25).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
