johanpel edited a comment on pull request #11883:
URL: https://github.com/apache/arrow/pull/11883#issuecomment-988626282


   Thanks for the comments. I added the docs. I also added a test because the 
function can be applied to String/LargeString as well. I'm in doubt whether we 
would want to prevent applying this function to String/LargeString. Use cases 
would be quite exotic.
   
   If we'd like to prevent it I could introduce `BinaryTypes()` with 
`{binary(), large_binary()}` in `arrow/type.h` and use that to add the kernel 
to the registry only for these types, but I'm not sure if this would have 
further implications for the rest of the codebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to