matthewmturner commented on a change in pull request #984:
URL: https://github.com/apache/arrow-rs/pull/984#discussion_r765200445
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -200,6 +201,54 @@ macro_rules! compare_op_scalar_primitive {
}};
}
+macro_rules! compare_dict_op_scalar {
+ ($left:expr, $T:ident, $right:expr, $op:expr) => {{
+ let null_bit_buffer = $left
+ .data()
+ .null_buffer()
+ .map(|b| b.bit_slice($left.offset(), $left.len()));
+
+ let values = $left.values();
+
+ let array = values
+ .as_any()
+ .downcast_ref::<PrimitiveArray<$T>>()
+ .unwrap();
+
+ // Safety:
+ // `i < $left.len()`
+ let comparison: Vec<bool> = (0..array.len())
Review comment:
if youre referring to the safety comment i just hadnt removed that yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
