rip-nsk commented on a change in pull request #11887:
URL: https://github.com/apache/arrow/pull/11887#discussion_r765383454
##########
File path: cpp/src/arrow/util/launder.h
##########
@@ -22,7 +22,7 @@
namespace arrow {
namespace internal {
-#if __cplusplus >= 201703L
+#ifdef __cpp_lib_launder
Review comment:
if __cpp_lib_launder defined, std::launder is available for sure,
otherwise, it could be not present even for specified __cplusplus version.
in my opinion, best solution here macro option like HAS_STD_LAUNDER defined
at cmake configuration stage, but proposed variant should work too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
