liukun4515 commented on a change in pull request #1423:
URL: https://github.com/apache/arrow-datafusion/pull/1423#discussion_r765834244
##########
File path: datafusion/src/sql/planner.rs
##########
@@ -1989,10 +1989,10 @@ fn extract_possible_join_keys(
pub fn convert_data_type(sql: &SQLDataType) -> Result<DataType> {
match sql {
SQLDataType::Boolean => Ok(DataType::Boolean),
- SQLDataType::SmallInt(_display) => Ok(DataType::Int16),
- SQLDataType::Int(_display) => Ok(DataType::Int32),
- SQLDataType::BigInt(_display) => Ok(DataType::Int64),
- SQLDataType::Float(_) => Ok(DataType::Float64),
+ SQLDataType::SmallInt(_) => Ok(DataType::Int16),
+ SQLDataType::Int(_) => Ok(DataType::Int32),
+ SQLDataType::BigInt(_) => Ok(DataType::Int64),
+ SQLDataType::Float(_) => Ok(DataType::Float32),
Review comment:
Yes.
In the datafusion
[README.md](https://github.com/apache/arrow-datafusion/blob/6955a8d9279bf06311fe0d9d7428854b0601059d/README.md?plain=1#L345),
the SQL float is corresponding to the arrow-FLOAT32.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
