pitrou commented on a change in pull request #11919:
URL: https://github.com/apache/arrow/pull/11919#discussion_r766017291
##########
File path: r/src/arrow_cpp11.h
##########
@@ -57,13 +57,45 @@ namespace r {
template <typename T>
struct Pointer {
Pointer() : ptr_(new T()) {}
- explicit Pointer(SEXP x)
- : ptr_(reinterpret_cast<T*>(static_cast<uintptr_t>(REAL(x)[0]))) {}
+ explicit Pointer(SEXP x) {
+ if (TYPEOF(x) == EXTPTRSXP) {
+ ptr_ = (T*)R_ExternalPtrAddr(x);
+ } else if (TYPEOF(x) == STRSXP && Rf_length(x) == 1) {
+ // User passed an character representation of the pointer address
+ SEXP char0 = STRING_ELT(x, 0);
+ if (char0 == NA_STRING) {
+ cpp11::stop("Can't convert NA_character_ to pointer");
+ }
+
+ const char* input_chars = CHAR(char0);
+ char* endptr;
+ uint64_t ptr_value = strtoll(input_chars, &endptr, 0);
Review comment:
Perhaps use `strotoull`, since you're converting to unsigned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
