alamb commented on a change in pull request #998:
URL: https://github.com/apache/arrow-rs/pull/998#discussion_r766036159



##########
File path: arrow/src/compute/kernels/partition.rs
##########
@@ -77,24 +74,51 @@ impl<'a> LexicographicalPartitionIterator<'a> {
 /// see <https://en.wikipedia.org/wiki/Exponential_search>
 #[inline]
 fn exponential_search(

Review comment:
       Can you please document what `start` and `end` and `bound` are?  
(specifically how the relate to each other -- I think as written it seems like 
`bound` is some starting index and the search starts at `start+bound` and stops 
at `end` indexes?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to