westonpace commented on a change in pull request #11857:
URL: https://github.com/apache/arrow/pull/11857#discussion_r766102031
##########
File path: cpp/src/arrow/csv/writer.cc
##########
@@ -80,15 +80,19 @@ int64_t CountQuotes(util::string_view s) {
// Matching quote pair character length.
constexpr int64_t kQuoteCount = 2;
constexpr int64_t kQuoteDelimiterCount = kQuoteCount + /*end_char*/ 1;
+constexpr char const* kStrComma = ",";
Review comment:
```suggestion
constexpr const char * kStrComma = ",";
```
See:
https://medium.com/@samathy_barratt/constantly-confusing-c-const-and-constexpr-pointer-behaviour-7eddb041e15a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
