anthonylouisbsb commented on a change in pull request #10742:
URL: https://github.com/apache/arrow/pull/10742#discussion_r766245087
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -892,6 +892,28 @@ const char* gdv_fn_aes_decrypt(int64_t context, const
char* data, int32_t data_l
return ret;
}
+
+// Expand inner macro for all integer types.
+#define NEGATIVE_FN_INTEGER_PARAMS(INNER) \
Review comment:
@projjal because I use the `std::numeric_limits<gdv_##TYPE>::min()`
function to avoid overflow and if I remember, we can not use functions from
stdlib in precompiled code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
