Dandandan commented on a change in pull request #1431:
URL: https://github.com/apache/arrow-datafusion/pull/1431#discussion_r766728006
##########
File path: datafusion/src/sql/planner.rs
##########
@@ -2006,6 +2026,27 @@ pub fn convert_data_type(sql: &SQLDataType) ->
Result<DataType> {
SQLDataType::Char(_) | SQLDataType::Varchar(_) => Ok(DataType::Utf8),
SQLDataType::Timestamp => Ok(DataType::Timestamp(TimeUnit::Nanosecond,
None)),
SQLDataType::Date => Ok(DataType::Date32),
+ SQLDataType::Decimal(precision, scale) => {
+ match (precision, scale) {
+ (None, _) | (_, None) => {
+ return Err(DataFusionError::Internal(format!(
+ "Error Decimal Type ({:?})",
+ sql_type
+ )));
+ }
+ (Some(p), Some(s)) => {
+ // TODO add bound checker in some utils file or function
+ if *p > 38 || *s > *p {
+ return Err(DataFusionError::Internal(format!(
+ "Error Decimal Type ({:?})",
Review comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
